Our Flaky Test Was Actually a Daylight Saving Time Bug Hiding for Three Years
It failed twice a year, always on a Monday, and we kept clicking re-run.
It failed twice a year, always on a Monday, and we kept clicking re-run.
Most retry code I review makes outages worse. Here is the small, dull version that actually helps.
After six years and roughly 4,000 reviews, I quietly retired some of my favourite nitpicks. Here is the list and the reasons.
It is the cheapest design review I know, and it has killed three of my own bad ideas.
Two servers, one nightly job, and invoices that went out twice. The fix was eleven lines.
A practical, slightly embarrassing walk through cleaning real-world dates with pandas, and the rules I now follow on every import.
The browser already ships a world-class date formatter. I just never bothered to look.
One listener on a parent can replace hundreds on children, and the browser has made it nicer than ever.
I thought I was bad at concurrency. It turns out I am bad at reading error messages to the end.
Nobody asked me to remove the dead code, which is exactly why it had been sitting there for six years.